Add support for ALTCHA, an alternative to current Google Recaptcha #10456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 19, 2024
asmecher
requested changes
Nov 21, 2024
| } | ||
|
|
||
| if (!PKP_STRICT_MODE) { | ||
| class_alias('\PKP\form\validation\FormValidatorAltcha', '\FormValidatorAltcha'); |
There was a problem hiding this comment.
Unless it's required for some other reason, the class_aliases should only be provided for backwards compatibility; new code shouldn't require it except in a few exceptional cases.
js/lib/altcha/altcha.min.js
Outdated
| @@ -0,0 +1,8 @@ | |||
| /** | |||
There was a problem hiding this comment.
Rather than committing 3rd-party code directly to our repository, is it possible to install this via an NPM dependency or, failing that, possibly even with Composer?
pages/login/LoginHandler.php
Outdated
| * @param string $altchaConfigKey the key to search on config.inc.php | ||
| * @param TemplateManager $templateMgr | ||
| */ | ||
| private function generateAltchaComponent($altchaConfigKey, &$templateMgr): void |
There was a problem hiding this comment.
Wherever possible, add typehints in new code; also remove redundant code self-documentation while you're at it. The @param string $altchaConfigKey adds a description, so it's valuable, but once it has a typehint, @param TemplateManager $templateMgr adds nothing and should be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.